From dfb2bd97d466117d8964b4737d06bc1b6669eefe Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sat, 3 Feb 2024 11:25:14 +0100 Subject: [PATCH] ci: remove msrv.yml workflow as it's not really used If it does become relevant to actually implement this is can be done at that time. Having a non-functional stub isn't useful. --- .github/workflows/CICD.yml | 9 +------- .github/workflows/msrv.yml | 42 -------------------------------------- 2 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 .github/workflows/msrv.yml diff --git a/.github/workflows/CICD.yml b/.github/workflows/CICD.yml index a700f4d8..b4926d51 100644 --- a/.github/workflows/CICD.yml +++ b/.github/workflows/CICD.yml @@ -43,13 +43,6 @@ jobs: checks: uses: ./.github/workflows/checks.yml - min_version: - name: Minimum supported rust version - needs: checks - uses: ./.github/workflows/msrv.yml - with: - package: tree-sitter-cli - sanitize: name: Sanitize needs: [init, checks] @@ -64,7 +57,7 @@ jobs: release: name: Release - needs: [init, checks, min_version, build, sanitize] + needs: [init, checks, build, sanitize] if: > github.event_name == 'pull_request' && startsWith(github.head_ref, 'release/v') && diff --git a/.github/workflows/msrv.yml b/.github/workflows/msrv.yml deleted file mode 100644 index 3697930e..00000000 --- a/.github/workflows/msrv.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: Minimum supported rust version - -env: - CARGO_TERM_COLOR: always - RUSTFLAGS: "-D warnings" - -on: - workflow_call: - inputs: - package: - description: Target cargo package name - required: true - type: string - - -jobs: - run: - name: Run checks - runs-on: ubuntu-latest - steps: - - - name: Checkout source code - uses: actions/checkout@v3 - - - name: Get the MSRV from the package metadata - id: msrv - run: cargo metadata --no-deps --format-version 1 | jq -r '"version=" + (.packages[] | select(.name == "${{ inputs.package }}").rust_version)' >> $GITHUB_OUTPUT - - - name: Install rust toolchain (v${{ steps.msrv.outputs.version }}) - uses: dtolnay/rust-toolchain@master - with: - toolchain: ${{ steps.msrv.outputs.version }} - components: clippy, rustfmt - - - name: Run cargo fmt - run: cargo fmt -- --check - - # - name: Run clippy (on minimum supported rust version to prevent warnings we can't fix) - # run: cargo clippy --all-targets - - # - name: Run main tests - # run: cargo test