query: Handle #not-match? in rust, wasm bindings

This commit is contained in:
Max Brunsfeld 2020-07-24 10:49:20 -07:00
parent 32099050d6
commit 1ae5cbc851
4 changed files with 25 additions and 7 deletions

View file

@ -1470,12 +1470,17 @@ fn test_query_captures_with_text_conditions() {
((identifier) @function.builtin
(#eq? @function.builtin "require"))
(identifier) @variable
((identifier) @variable
(#not-match? @variable "^(lambda|load)$"))
"#,
)
.unwrap();
let source = "
toad
load
panda
lambda
const ab = require('./ab');
new Cd(EF);
";
@ -1489,6 +1494,8 @@ fn test_query_captures_with_text_conditions() {
assert_eq!(
collect_captures(captures, &query, source),
&[
("variable", "toad"),
("variable", "panda"),
("variable", "ab"),
("function.builtin", "require"),
("variable", "require"),

View file

@ -169,7 +169,7 @@ pub enum QueryError {
enum TextPredicate {
CaptureEqString(u32, String, bool),
CaptureEqCapture(u32, u32, bool),
CaptureMatchString(u32, regex::bytes::Regex),
CaptureMatchString(u32, regex::bytes::Regex, bool),
}
impl Language {
@ -1298,7 +1298,7 @@ impl Query {
});
}
"match?" => {
"match?" | "not-match?" => {
if p.len() != 3 {
return Err(QueryError::Predicate(format!(
"Wrong number of arguments to #match? predicate. Expected 2, got {}.",
@ -1318,12 +1318,14 @@ impl Query {
)));
}
let is_positive = operator_name == "match?";
let regex = &string_values[p[2].value_id as usize];
text_predicates.push(TextPredicate::CaptureMatchString(
p[1].value_id,
regex::bytes::Regex::new(regex).map_err(|_| {
QueryError::Predicate(format!("Invalid regex '{}'", regex))
})?,
is_positive,
));
}
@ -1607,9 +1609,9 @@ impl<'a> QueryMatch<'a> {
let node = self.capture_for_index(*i).unwrap();
(text_callback(node).as_ref() == s.as_bytes()) == *is_positive
}
TextPredicate::CaptureMatchString(i, r) => {
TextPredicate::CaptureMatchString(i, r, is_positive) => {
let node = self.capture_for_index(*i).unwrap();
r.is_match(text_callback(node).as_ref())
r.is_match(text_callback(node).as_ref()) == *is_positive
}
})
}

View file

@ -784,6 +784,8 @@ class Language {
}
break;
case 'not-match?':
isPositive = false;
case 'match?':
if (steps.length !== 3) throw new Error(
`Wrong number of arguments to \`#match?\` predicate. Expected 2, got ${steps.length - 1}.`
@ -798,7 +800,7 @@ class Language {
const regex = new RegExp(steps[2].value);
textPredicates[i].push(function(captures) {
for (const c of captures) {
if (c.name === captureName) return regex.test(c.node.text);
if (c.name === captureName) return regex.test(c.node.text) === isPositive;
}
return false;
});

View file

@ -126,12 +126,17 @@ describe("Query", () => {
it("handles conditions that compare the text of capture to literal strings", () => {
tree = parser.parse(`
lambda
panda
load
toad
const ab = require('./ab');
new Cd(EF);
`);
query = JavaScript.query(`
(identifier) @variable
((identifier) @variable
(#not-match? @variable "^(lambda|load)$"))
((identifier) @function.builtin
(#eq? @function.builtin "require"))
@ -145,6 +150,8 @@ describe("Query", () => {
const captures = query.captures(tree.rootNode);
assert.deepEqual(formatCaptures(captures), [
{ name: "variable", text: "panda" },
{ name: "variable", text: "toad" },
{ name: "variable", text: "ab" },
{ name: "variable", text: "require" },
{ name: "function.builtin", text: "require" },