From 3210c7e21fc8894f4515809a17da6ea354e647f6 Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Fri, 12 Apr 2024 12:01:23 -0700 Subject: [PATCH] Avoid using a large character set constant when it doesn't reduce code size --- cli/src/generate/render.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cli/src/generate/render.rs b/cli/src/generate/render.rs index 00c414ae..f0ac0ab2 100644 --- a/cli/src/generate/render.rs +++ b/cli/src/generate/render.rs @@ -731,10 +731,14 @@ impl Generator { if !intersection.is_empty() { let additions = chars_copy.simplify_ignoring(&ruled_out_chars); let removals = large_set.simplify_ignoring(&ruled_out_chars); + let total_range_count = additions.range_count() + removals.range_count(); + if total_range_count >= simplified_chars.range_count() { + continue; + } if let Some((_, best_additions, best_removals)) = &best_large_char_set { - if best_additions.range_count() + best_removals.range_count() - < additions.range_count() + removals.range_count() - { + let best_range_count = + best_additions.range_count() + best_removals.range_count(); + if best_range_count < total_range_count { continue; } }