traxys/tree-sitter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: hoist out common subexpressions in satisfies_text_predicates

Browse source 
This commit stores the result of text predicates evaluation in a separate variable to ensure that they're computed just once. As is, it is possible for e.g. #match predicates to match node against a regex twice.
This commit is contained in:
Piotr Osiewicz 2024-06-03 14:25:30 +02:00 • committed by GitHub
parent 6304009209
commit 3c3699ba90
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/binding_rust/lib.rs
View file

@ -2551,10 +2551,11 @@ impl<'tree> QueryMatch<'_, 'tree> {
let mut text2 = text_provider.text(node2);
let text1 = node_text1.get_text(&mut text1);
let text2 = node_text2.get_text(&mut text2);
if (text1 == text2) != *is_positive && *match_all_nodes {
let is_positive_match = text1 == text2;
if is_positive_match != *is_positive && *match_all_nodes {
return false;
}
if (text1 == text2) == *is_positive && !*match_all_nodes {
if is_positive_match == *is_positive && !*match_all_nodes {
return true;
}
}
@ -2565,10 +2566,11 @@ impl<'tree> QueryMatch<'_, 'tree> {
for node in nodes {
let mut text = text_provider.text(node);
let text = node_text1.get_text(&mut text);
if (text == s.as_bytes()) != *is_positive && *match_all_nodes {
let is_positive_match = text == s.as_bytes();
if is_positive_match != *is_positive && *match_all_nodes {
return false;
}
if (text == s.as_bytes()) == *is_positive && !*match_all_nodes {
if is_positive_match == *is_positive && !*match_all_nodes {
return true;
}
}
@ -2579,10 +2581,11 @@ impl<'tree> QueryMatch<'_, 'tree> {
for node in nodes {
let mut text = text_provider.text(node);
let text = node_text1.get_text(&mut text);
if (r.is_match(text)) != *is_positive && *match_all_nodes {
let is_positive_match = r.is_match(text);
if is_positive_match != *is_positive && *match_all_nodes {
return false;
}
if (r.is_match(text)) == *is_positive && !*match_all_nodes {
if is_positive_match == *is_positive && !*match_all_nodes {
return true;
}
}