From 59838de33ae64b3a292dcd8e401afa2eb9aeb11a Mon Sep 17 00:00:00 2001 From: Christian Clason Date: Wed, 28 Feb 2024 15:18:37 +0100 Subject: [PATCH] ci: don't skip tests on failing lint Problem: A failing lint will block running actual tests, adding friction to contributors who will have to golf the linter before getting to see actually useful test results. Solution: Don't gate `sanitize` and `build` behind successful `checks` so you can see whether your code works at all _before_ worrying about its quality. (In general, the more feedback you get at the same time, the fewer edit->push->test cycles you need, _saving_ CI time in the long run. Only skip tests you are sure to be useless given previous failures.) --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45ec74f0..88af7114 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,9 +15,7 @@ jobs: uses: ./.github/workflows/checks.yml sanitize: - needs: checks uses: ./.github/workflows/sanitize.yml build: - needs: checks uses: ./.github/workflows/build.yml