From a2f2b16acb67a7659331ab12ab7cfbef4567ba31 Mon Sep 17 00:00:00 2001
From: WillLillis <wlillis@umass.edu>
Date: Mon, 6 Oct 2025 01:53:00 -0400
Subject: [PATCH] fix(xtask): require `version` argument for `bump-version`
 command

---
 crates/xtask/src/bump.rs | 100 +--------------------------------------
 crates/xtask/src/main.rs |   4 +-
 2 files changed, 4 insertions(+), 100 deletions(-)

diff --git a/crates/xtask/src/bump.rs b/crates/xtask/src/bump.rs
index 7e5f5dcd..02254274 100644
--- a/crates/xtask/src/bump.rs
+++ b/crates/xtask/src/bump.rs
@@ -2,7 +2,7 @@ use std::{cmp::Ordering, path::Path};
 
 use anyhow::{anyhow, Context, Result};
 use indoc::indoc;
-use semver::{BuildMetadata, Prerelease, Version};
+use semver::{Prerelease, Version};
 
 use crate::{create_commit, BumpVersion};
 
@@ -48,7 +48,6 @@ pub fn run(args: BumpVersion) -> Result<()> {
             String::from_utf8_lossy(&output.stderr)
         );
     }
-    let latest_tag_sha = String::from_utf8(output.stdout)?.trim().to_string();
 
     let workspace_toml_version = Version::parse(&fetch_workspace_version()?)?;
 
@@ -65,102 +64,7 @@ pub fn run(args: BumpVersion) -> Result<()> {
         return Ok(());
     }
 
-    let output = std::process::Command::new("git")
-        .args(["rev-list", &format!("{latest_tag_sha}..HEAD")])
-        .output()?;
-    if !output.status.success() {
-        anyhow::bail!(
-            "Failed to get commits: {}",
-            String::from_utf8_lossy(&output.stderr)
-        );
-    }
-    let commits = String::from_utf8(output.stdout)?
-        .lines()
-        .map(|s| s.to_string())
-        .collect::<Vec<_>>();
-
-    let mut should_increment_patch = false;
-    let mut should_increment_minor = false;
-
-    for commit_sha in commits {
-        let output = std::process::Command::new("git")
-            .args(["log", "-1", "--format=%s", &commit_sha])
-            .output()?;
-        if !output.status.success() {
-            continue;
-        }
-        let message = String::from_utf8(output.stdout)?.trim().to_string();
-
-        let output = std::process::Command::new("git")
-            .args([
-                "diff-tree",
-                "--no-commit-id",
-                "--name-only",
-                "-r",
-                &commit_sha,
-            ])
-            .output()?;
-        if !output.status.success() {
-            continue;
-        }
-
-        let mut source_code_changed = false;
-        for path in String::from_utf8(output.stdout)?.lines() {
-            let path = Path::new(path);
-            if path.extension().is_some_and(|ext| {
-                ext.eq_ignore_ascii_case("rs")
-                    || ext.eq_ignore_ascii_case("js")
-                    || ext.eq_ignore_ascii_case("c")
-            }) {
-                source_code_changed = true;
-                break;
-            }
-        }
-
-        if source_code_changed {
-            should_increment_patch = true;
-
-            let Some((prefix, _)) = message.split_once(':') else {
-                continue;
-            };
-
-            let convention = if prefix.contains('(') {
-                prefix.split_once('(').unwrap().0
-            } else {
-                prefix
-            };
-
-            if ["feat", "feat!"].contains(&convention) || prefix.ends_with('!') {
-                should_increment_minor = true;
-            }
-        }
-    }
-
-    let next_version = if let Some(version) = args.version {
-        version
-    } else {
-        let mut next_version = current_version.clone();
-        if should_increment_minor {
-            next_version.minor += 1;
-            next_version.patch = 0;
-            next_version.pre = Prerelease::EMPTY;
-            next_version.build = BuildMetadata::EMPTY;
-        } else if should_increment_patch {
-            next_version.patch += 1;
-            next_version.pre = Prerelease::EMPTY;
-            next_version.build = BuildMetadata::EMPTY;
-        } else {
-            return Err(anyhow!(format!(
-                "No source code changed since {current_version}"
-            )));
-        }
-        next_version
-    };
-    if next_version <= current_version {
-        return Err(anyhow!(format!(
-            "Next version {next_version} must be greater than current version {current_version}"
-        )));
-    }
+    let next_version = args.version;
 
     println!("Bumping from {current_version} to {next_version}");
     update_crates(&current_version, &next_version)?;
diff --git a/crates/xtask/src/main.rs b/crates/xtask/src/main.rs
index 57f81dae..46b2e796 100644
--- a/crates/xtask/src/main.rs
+++ b/crates/xtask/src/main.rs
@@ -94,8 +94,8 @@ struct BuildWasm {
 #[derive(Args)]
 struct BumpVersion {
     /// The version to bump to.
-    #[arg(long, short)]
-    version: Option<Version>,
+    #[arg(index = 1, required = true)]
+    version: Version,
 }
 
 #[derive(Args)]