From b742e88108e9e79b9e2fe825fb8c6b9dfa0c5a5c Mon Sep 17 00:00:00 2001
From: Douglas Creager <dcreager@dcreager.net>
Date: Wed, 28 Apr 2021 15:46:12 -0400
Subject: [PATCH] Use TRANSFER_BUFFER for did_exceed_match_limit

This bridges the gap between how the C API reports this for a query
cursor, but the wasm API defines the method on a query.  Whenever you
call a query method that might exceed the match limit, we call the C API
function and transfer the result across the wasm boundary, storing the
result in the JavaScript wrapper class.
---
 lib/binding_web/binding.c    | 13 ++++++-------
 lib/binding_web/binding.js   |  7 ++++++-
 lib/binding_web/exports.json |  1 -
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/lib/binding_web/binding.c b/lib/binding_web/binding.c
index c605731e..8adaec75 100644
--- a/lib/binding_web/binding.c
+++ b/lib/binding_web/binding.c
@@ -622,8 +622,11 @@ void ts_query_matches_wasm(
     }
   }
 
+  bool did_exceed_match_limit =
+    ts_query_cursor_did_exceed_match_limit(scratch_query_cursor);
   TRANSFER_BUFFER[0] = (const void *)(match_count);
   TRANSFER_BUFFER[1] = result.contents;
+  TRANSFER_BUFFER[2] = (const void *)(did_exceed_match_limit);
 }
 
 void ts_query_captures_wasm(
@@ -667,13 +670,9 @@ void ts_query_captures_wasm(
     }
   }
 
+  bool did_exceed_match_limit =
+    ts_query_cursor_did_exceed_match_limit(scratch_query_cursor);
   TRANSFER_BUFFER[0] = (const void *)(capture_count);
   TRANSFER_BUFFER[1] = result.contents;
-}
-
-bool ts_query_did_exceed_match_limit_wasm(
-  const TSQuery *self
-) {
-  if (!scratch_query_cursor) return false;
-  return ts_query_cursor_did_exceed_match_limit(scratch_query_cursor);
+  TRANSFER_BUFFER[2] = (const void *)(did_exceed_match_limit);
 }
diff --git a/lib/binding_web/binding.js b/lib/binding_web/binding.js
index a51a7aea..490874ac 100644
--- a/lib/binding_web/binding.js
+++ b/lib/binding_web/binding.js
@@ -945,6 +945,7 @@ class Query {
     this.setProperties = setProperties;
     this.assertedProperties = assertedProperties;
     this.refutedProperties = refutedProperties;
+    this.exceededMatchLimit = false;
   }
 
   delete() {
@@ -969,7 +970,9 @@ class Query {
 
     const rawCount = getValue(TRANSFER_BUFFER, 'i32');
     const startAddress = getValue(TRANSFER_BUFFER + SIZE_OF_INT, 'i32');
+    const didExceedMatchLimit = getValue(TRANSFER_BUFFER + 2 * SIZE_OF_INT, 'i32');
     const result = new Array(rawCount);
+    this.exceededMatchLimit = !!didExceedMatchLimit;
 
     let filteredCount = 0;
     let address = startAddress;
@@ -1014,7 +1017,9 @@ class Query {
 
     const count = getValue(TRANSFER_BUFFER, 'i32');
     const startAddress = getValue(TRANSFER_BUFFER + SIZE_OF_INT, 'i32');
+    const didExceedMatchLimit = getValue(TRANSFER_BUFFER + 2 * SIZE_OF_INT, 'i32');
     const result = [];
+    this.exceededMatchLimit = !!didExceedMatchLimit;
 
     const captures = [];
     let address = startAddress;
@@ -1050,7 +1055,7 @@ class Query {
   }
 
   didExceedMatchLimit() {
-    return C._ts_query_did_exceed_match_limit_wasm(this[0]);
+    return this.exceededMatchLimit;
   }
 }
 
diff --git a/lib/binding_web/exports.json b/lib/binding_web/exports.json
index 7e73a11a..b2b4449d 100644
--- a/lib/binding_web/exports.json
+++ b/lib/binding_web/exports.json
@@ -76,7 +76,6 @@
   "_ts_query_capture_name_for_id",
   "_ts_query_captures_wasm",
   "_ts_query_delete",
-  "_ts_query_did_exceed_match_limit_wasm",
   "_ts_query_matches_wasm",
   "_ts_query_new",
   "_ts_query_pattern_count",