Explicitly compare regions between subtrees in get_changed_ranges

This commit is contained in:
Max Brunsfeld 2017-08-06 17:16:29 -07:00
parent f5aa633011
commit ed11ddbd38
2 changed files with 176 additions and 165 deletions

View file

@ -24,13 +24,14 @@ typedef struct {
TreePath path;
const TSLanguage *language;
unsigned visible_depth;
bool in_padding;
} Iterator;
static Iterator iterator_new(TreePath *path, Tree *tree, const TSLanguage *language) {
array_clear(path);
array_push(path, ((TreePathEntry){
.tree = tree,
.position = { 0, 0, { 0, 0 } },
.position = length_zero(),
.child_index = 0,
.structural_child_index = 0,
}));
@ -38,23 +39,33 @@ static Iterator iterator_new(TreePath *path, Tree *tree, const TSLanguage *langu
.path = *path,
.language = language,
.visible_depth = 1,
.in_padding = false,
};
}
Length iterator_start_position(Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
return length_add(entry.position, entry.tree->padding);
}
Length iterator_end_position(Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
return length_add(length_add(entry.position, entry.tree->padding), entry.tree->size);
}
static bool iterator_done(Iterator *self) {
return self->path.size == 0;
}
Length iterator_start_position(Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
if (self->in_padding) {
return entry.position;
} else {
return length_add(entry.position, entry.tree->padding);
}
}
Length iterator_end_position(Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
Length result = length_add(entry.position, entry.tree->padding);
if (self->in_padding) {
return result;
} else {
return length_add(result, entry.tree->size);
}
}
static bool iterator_tree_is_visible(const Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
if (entry.tree->visible) return true;
@ -66,109 +77,127 @@ static bool iterator_tree_is_visible(const Iterator *self) {
return false;
}
static void iterator_print_state(Iterator *self) {
TreePathEntry entry = *array_back(&self->path);
TSPoint start = point_add(entry.position.extent, entry.tree->padding.extent);
TSPoint end = point_add(start, entry.tree->size.extent);
const char *name = ts_language_symbol_name(self->language, entry.tree->symbol);
printf("(%-25s\t depth:%u [%u, %u] - [%u, %u])", name, self->visible_depth, start.row, start.column, end.row, end.column);
}
static void iterator_get_visible_state(const Iterator *self, Tree **tree,
TSSymbol *alias_symbol, uint32_t *start_byte) {
uint32_t i = self->path.size - 1;
static void iterator_ascend(Iterator *self) {
bool did_ascend = false;
for (;;) {
if (iterator_done(self)) break;
if (iterator_tree_is_visible(self)) {
if (did_ascend) break;
did_ascend = true;
self->visible_depth--;
if (self->in_padding) {
while (self->path.contents[i].child_index == 0) i--;
}
for (; i + 1 > 0; i--) {
TreePathEntry entry = self->path.contents[i];
if (i > 0) {
Tree *parent = self->path.contents[i - 1].tree;
const TSSymbol *alias_sequence = ts_language_alias_sequence(
self->language,
parent->alias_sequence_id
);
if (alias_sequence) {
*alias_symbol = alias_sequence[entry.structural_child_index];
}
}
if (entry.tree->visible || *alias_symbol) {
*tree = entry.tree;
*start_byte = entry.position.bytes;
break;
}
self->path.size--;
}
}
static bool iterator_descend(Iterator *self, Length position) {
uint32_t original_size = self->path.size;
static void iterator_ascend(Iterator *self) {
if (iterator_done(self)) return;
if (iterator_tree_is_visible(self) && !self->in_padding) self->visible_depth--;
if (array_back(&self->path)->child_index > 0) self->in_padding = false;
self->path.size--;
}
static bool iterator_descend(Iterator *self, uint32_t goal_position) {
if (self->in_padding) return false;
bool did_descend;
do {
did_descend = false;
TreePathEntry entry = *array_back(&self->path);
Length child_left = entry.position;
Length position = entry.position;
uint32_t structural_child_index = 0;
for (uint32_t i = 0; i < entry.tree->child_count; i++) {
Tree *child = entry.tree->children[i];
Length child_right = length_add(child_left, ts_tree_total_size(child));
Length child_left = length_add(position, child->padding);
Length child_right = length_add(child_left, child->size);
if (child_right.bytes > position.bytes) {
if (child_right.bytes > goal_position) {
array_push(&self->path, ((TreePathEntry){
.tree = child,
.position = child_left,
.position = position,
.child_index = i,
.structural_child_index = structural_child_index,
}));
if (iterator_tree_is_visible(self)) {
self->visible_depth++;
if (child_left.bytes > goal_position) {
self->in_padding = true;
} else {
self->visible_depth++;
}
return true;
}
if (child->visible_child_count > 0) {
did_descend = true;
break;
}
self->path.size--;
did_descend = true;
break;
}
child_left = child_right;
position = child_right;
if (!child->extra) structural_child_index++;
}
} while (did_descend);
self->path.size = original_size;
return false;
}
static bool iterator_advance(Iterator *self) {
if (iterator_done(self)) return false;
static void iterator_advance(Iterator *self) {
if (self->in_padding) {
self->in_padding = false;
if (iterator_tree_is_visible(self)) {
self->visible_depth++;
} else {
iterator_descend(self, 0);
}
return;
}
for (;;) {
if (iterator_tree_is_visible(self)) self->visible_depth--;
TreePathEntry entry = array_pop(&self->path);
if (iterator_done(self)) return false;
if (iterator_done(self)) return;
Tree *parent = array_back(&self->path)->tree;
Length position = length_add(entry.position, ts_tree_total_size(entry.tree));
uint32_t structural_child_index = entry.structural_child_index;
if (!entry.tree->extra) structural_child_index++;
uint32_t child_index = entry.child_index + 1;
if (parent->child_count > child_index) {
Length position = length_add(entry.position, ts_tree_total_size(entry.tree));
uint32_t structural_child_index = entry.structural_child_index;
if (!entry.tree->extra) structural_child_index++;
Tree *next_child = parent->children[child_index];
for (uint32_t i = entry.child_index + 1; i < parent->child_count; i++) {
Tree *next_child = parent->children[i];
array_push(&self->path, ((TreePathEntry){
.tree = next_child,
.position = position,
.child_index = i,
.child_index = child_index,
.structural_child_index = structural_child_index,
}));
if (iterator_tree_is_visible(self)) {
self->visible_depth++;
return true;
if (next_child->padding.bytes > 0) {
self->in_padding = true;
} else {
self->visible_depth++;
}
} else {
iterator_descend(self, 0);
}
if (next_child->visible_child_count > 0) {
iterator_descend(self, length_zero());
return true;
}
if (next_child->child_count == 0) {
return true;
}
self->path.size--;
position = length_add(position, ts_tree_total_size(next_child));
if (!next_child->extra) structural_child_index++;
break;
}
}
}
@ -179,50 +208,23 @@ typedef enum {
IteratorMatches,
} IteratorComparison;
IteratorComparison iterator_compare(const Iterator *self, const Iterator *other) {
Tree *old_tree = NULL;
TSSymbol old_alias_symbol = 0;
Length old_start = length_zero();
for (uint32_t i = self->path.size - 1; i + 1 > 0; i--) {
old_tree = self->path.contents[i].tree;
old_start = self->path.contents[i].position;
if (i > 0) {
Tree *parent = self->path.contents[i - 1].tree;
const TSSymbol *alias_sequence = ts_language_alias_sequence(self->language, parent->alias_sequence_id);
if (alias_sequence) {
old_alias_symbol = alias_sequence[self->path.contents[i].structural_child_index];
}
}
if (old_tree->visible || old_alias_symbol) break;
}
Tree *new_tree = NULL;
TSSymbol new_alias_symbol = 0;
Length new_start = length_zero();
for (uint32_t i = other->path.size - 1; i + 1 > 0; i--) {
new_tree = other->path.contents[i].tree;
new_start = other->path.contents[i].position;
if (i > 0) {
Tree *parent = other->path.contents[i - 1].tree;
const TSSymbol *alias_sequence = ts_language_alias_sequence(self->language, parent->alias_sequence_id);
if (alias_sequence) {
new_alias_symbol = alias_sequence[other->path.contents[i].structural_child_index];
}
}
if (new_tree->visible || new_alias_symbol) break;
}
IteratorComparison iterator_compare(const Iterator *old_iter, const Iterator *new_iter) {
Tree *old_tree, *new_tree;
uint32_t old_start, new_start;
TSSymbol old_alias_symbol, new_alias_symbol;
iterator_get_visible_state(old_iter, &old_tree, &old_alias_symbol, &old_start);
iterator_get_visible_state(new_iter, &new_tree, &new_alias_symbol, &new_start);
if (old_alias_symbol == new_alias_symbol) {
if (old_start.bytes == new_start.bytes) {
if (old_start == new_start) {
if (!old_tree->has_changes &&
old_tree->symbol == new_tree->symbol &&
old_tree->symbol != ts_builtin_sym_error &&
old_tree->size.bytes == new_tree->size.bytes &&
old_tree->parse_state != TS_TREE_STATE_NONE &&
new_tree->parse_state != TS_TREE_STATE_NONE &&
(old_tree->parse_state == ERROR_STATE) == (new_tree->parse_state == ERROR_STATE)) {
(old_tree->parse_state == ERROR_STATE) ==
(new_tree->parse_state == ERROR_STATE)) {
return IteratorMatches;
}
}
@ -235,85 +237,94 @@ IteratorComparison iterator_compare(const Iterator *self, const Iterator *other)
return IteratorDiffers;
}
// static inline void iterator_print_state(Iterator *self) {
// TreePathEntry entry = *array_back(&self->path);
// TSPoint start = iterator_start_position(self).extent;
// TSPoint end = iterator_end_position(self).extent;
// const char *name = ts_language_symbol_name(self->language, entry.tree->symbol);
// printf(
// "(%-25s %s\t depth:%u [%u, %u] - [%u, %u])",
// name, self->in_padding ? "(p)" : " ",
// self->visible_depth,
// start.row, start.column,
// end.row, end.column
// );
// }
unsigned ts_tree_get_changed_ranges(Tree *old_tree, Tree *new_tree,
TreePath *path1, TreePath *path2,
const TSLanguage *language, TSRange **ranges) {
RangeArray results = array_new();
Iterator old_iter = iterator_new(path1, old_tree, language);
Iterator new_iter = iterator_new(path2, new_tree, language);
RangeArray results = array_new();
Length position = length_zero();
while (!iterator_done(&old_iter) && !iterator_done(&new_iter)) {
Length position = iterator_start_position(&old_iter);
Length next_position = iterator_start_position(&new_iter);
if (position.bytes < next_position.bytes) {
range_array_add(&results, position.extent, next_position.extent);
position = next_position;
} else if (position.bytes > next_position.bytes) {
range_array_add(&results, next_position.extent, position.extent);
next_position = position;
}
do {
// printf("At [%-2u, %-2u] Compare ", position.extent.row, position.extent.column);
// iterator_print_state(&old_iter);
// printf("\tvs\t");
// iterator_print_state(&new_iter);
// puts("");
bool is_changed = false;
Length next_position = position;
Length old_start = iterator_start_position(&old_iter);
Length new_start = iterator_start_position(&new_iter);
Length old_end = iterator_end_position(&old_iter);
Length new_end = iterator_end_position(&new_iter);
switch (iterator_compare(&old_iter, &new_iter)) {
case IteratorMatches:
next_position = iterator_end_position(&old_iter);
break;
if (position.bytes < old_start.bytes) {
if (position.bytes < new_start.bytes) {
next_position = length_min(old_start, new_start);
} else {
is_changed = true;
next_position = old_start;
}
} else if (position.bytes < new_start.bytes) {
is_changed = true;
next_position = new_start;
} else {
// printf("At [%-2u, %-2u] Compare ", position.extent.row, position.extent.column);
// iterator_print_state(&old_iter);
// printf("\tvs\t");
// iterator_print_state(&new_iter);
// printf("\n");
switch (iterator_compare(&old_iter, &new_iter)) {
case IteratorMatches:
next_position = old_end;
break;
case IteratorMayDiffer:
next_position = length_min(old_end, new_end);
if (iterator_descend(&old_iter, position)) {
if (iterator_descend(&new_iter, position)) {
next_position = position;
} else {
iterator_ascend(&old_iter);
is_changed = true;
}
} else if (iterator_descend(&new_iter, position)) {
iterator_ascend(&new_iter);
case IteratorMayDiffer:
if (iterator_descend(&old_iter, position.bytes)) {
if (!iterator_descend(&new_iter, position.bytes)) {
is_changed = true;
next_position = iterator_end_position(&old_iter);
}
break;
case IteratorDiffers:
next_position = length_min(old_end, new_end);
} else if (iterator_descend(&new_iter, position.bytes)) {
is_changed = true;
break;
}
next_position = iterator_end_position(&new_iter);
} else {
next_position = length_min(
iterator_end_position(&old_iter),
iterator_end_position(&new_iter)
);
}
break;
case IteratorDiffers:
is_changed = true;
next_position = length_min(
iterator_end_position(&old_iter),
iterator_end_position(&new_iter)
);
break;
}
while (old_end.bytes <= next_position.bytes && iterator_advance(&old_iter)) {
old_end = iterator_end_position(&old_iter);
}
while (
!iterator_done(&old_iter) &&
iterator_end_position(&old_iter).bytes <= next_position.bytes
) iterator_advance(&old_iter);
while (new_end.bytes <= next_position.bytes && iterator_advance(&new_iter)) {
new_end = iterator_end_position(&new_iter);
}
while (
!iterator_done(&new_iter) &&
iterator_end_position(&new_iter).bytes <= next_position.bytes
) iterator_advance(&new_iter);
while (old_iter.visible_depth > new_iter.visible_depth) {
iterator_ascend(&old_iter);
}
while (old_iter.visible_depth > new_iter.visible_depth) iterator_ascend(&old_iter);
while (new_iter.visible_depth > old_iter.visible_depth) {
iterator_ascend(&new_iter);
}
while (new_iter.visible_depth > old_iter.visible_depth) iterator_ascend(&new_iter);
if (is_changed) {
// printf(
// " changed range: [[%u, %u] - [%u, %u]]\n",
// " change: [[%u, %u] - [%u, %u]]\n",
// position.extent.row, position.extent.column,
// next_position.extent.row, next_position.extent.column
// );
@ -322,7 +333,7 @@ unsigned ts_tree_get_changed_ranges(Tree *old_tree, Tree *new_tree,
}
position = next_position;
}
} while (!iterator_done(&old_iter) && !iterator_done(&new_iter));
*path1 = old_iter.path;
*path2 = new_iter.path;

View file

@ -155,7 +155,7 @@ Tree *ts_tree_make_copy(Tree *self) {
void ts_tree_assign_parents(Tree *self, TreePath *path, const TSLanguage *language) {
array_clear(path);
array_push(path, ((TreePathEntry){self, length_zero(), 0}));
array_push(path, ((TreePathEntry){self, length_zero(), 0, 0}));
while (path->size > 0) {
Tree *tree = array_pop(path).tree;
Length offset = length_zero();
@ -175,7 +175,7 @@ void ts_tree_assign_parents(Tree *self, TreePath *path, const TSLanguage *langua
child->context.alias_symbol = 0;
child->context.alias_is_named = false;
}
array_push(path, ((TreePathEntry){child, length_zero(), 0}));
array_push(path, ((TreePathEntry){child, length_zero(), 0, 0}));
}
offset = length_add(offset, ts_tree_total_size(child));
if (!child->extra) non_extra_index++;