From b856f7e1bd0b87eb01dcc7c2d22a16c1a5bfed92 Mon Sep 17 00:00:00 2001 From: Andrew Hlynskyi Date: Thu, 29 Apr 2021 03:57:17 +0300 Subject: [PATCH 1/2] Remove unneeded dead_code annotations --- cli/src/generate/build_tables/item.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/cli/src/generate/build_tables/item.rs b/cli/src/generate/build_tables/item.rs index fc167151..32b1a8d9 100644 --- a/cli/src/generate/build_tables/item.rs +++ b/cli/src/generate/build_tables/item.rs @@ -75,7 +75,6 @@ pub(crate) struct TokenSetDisplay<'a>( pub &'a LexicalGrammar, ); -#[allow(dead_code)] pub(crate) struct ParseItemSetDisplay<'a>( pub &'a ParseItemSet<'a>, pub &'a SyntaxGrammar, @@ -181,7 +180,6 @@ impl<'a> Default for ParseItemSet<'a> { } } -#[allow(dead_code)] impl<'a> fmt::Display for ParseItemDisplay<'a> { fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> { if self.0.is_augmented() { From 9ee8ddb6b6a7f0bde5d25c703d4a4dd1d31b4008 Mon Sep 17 00:00:00 2001 From: Andrew Hlynskyi Date: Thu, 29 Apr 2021 04:02:16 +0300 Subject: [PATCH 2/2] Fail CI in case of compiler warnings like dead_code --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a1ac7a5c..65e051d4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -64,7 +64,7 @@ jobs: run: script/build-wasm - name: Build CLI - run: cargo build --release + run: RUSTFLAGS="-D warnings" cargo build --release - name: Set up fixture parsers run: |