traxys/tree-sitter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: don't skip tests on failing lint

Browse source 
Problem: A failing lint will block running actual tests, adding friction to contributors who will have to golf the linter before getting to see actually useful test results.

Solution: Don't gate `sanitize` and `build` behind successful `checks` so you can see whether your code works at all _before_ worrying about its quality. (In general, the more feedback you get at the same time, the fewer edit->push->test cycles you need, _saving_ CI time in the long run. Only skip tests you are sure to be useless given previous failures.)
This commit is contained in:
Christian Clason 2024-02-28 15:18:37 +01:00 • committed by dundargoc
parent d92a7a9690
commit 59838de33a
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View file

@ -15,9 +15,7 @@ jobs:
uses: ./.github/workflows/checks.yml
sanitize:
needs: checks
uses: ./.github/workflows/sanitize.yml
build:
needs: checks
uses: ./.github/workflows/build.yml